Re: [PATCH] Alert dialogs should not have window title according to the HIG



Am Sonntag, den 18.12.2005, 02:35 +0100 schrieb Martin Wehner:
> On Sun, 2005-12-18 at 02:04 +0100, Olav Vitters wrote:
> > On Sat, Dec 17, 2005 at 12:07:03AM -0800, Dennis Cranston wrote:
> > [..]
> > > I have attached a one line fix for the "untitled window" button problem.
> > 
> > [..]
> > >  	gtk_window_set_title (GTK_WINDOW (dialog), "");
> > > +	gtk_window_set_skip_taskbar_hint (GTK_WINDOW (dialog), TRUE);
> > >    	
> > >  	eel_alert_dialog_set_primary_label (EEL_ALERT_DIALOG (dialog),
> > >  	                                    primary_message);
> > 
> > Suggest to only set the icon title using gdk_window_set_icon_name. This
> > way the window border will have no name, the window list will and the
> > dialogs can still be seen in the window list.
> > 
> > -- 
> > Regards,
> > Olav
> 
> Yeah, that sounds like a good compromise. I just removed all the title
> arguments though :(
> Any takers?


If you still want to rever this please do it ASAP! Otherwise,
translators will kill us, they probably already removed some of the
strings from their .po files!
If you don't have enough time, and grant me the permission to do so I'll
revert it for you.

-- 
Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]