Re: [PATCH] Better handle location changes when original location is gone

[Alexander Larsson <alexl redhat com>]

On Sun, 2006-02-26 at 13:09 +0100, Christian Neumair wrote:
> Filed as bug 137027 [1]:
> 
> When a new location is loaded, and during that load the old location is
> marked gone, viewed_file_changed_callback is invoked and the window is
> closed. This happens when one goes up from a deleted directory with an
> existing parent directory. You can reproduce this with file monitoring
> disabled, i.e. on sftp URIs.
> 
> The attached patch tries to surpress that by cancelling the old
> callback. I haven't closely investigated whether this can break anything
> if the current directory is not gone and the old location is still
> used/viewed somehow. As long as update_for_new_location reconnects the
> old file, everything should work as expected.
> location_has_really_changed seems to be invoked on all URI change
> requests, including reloads.

No, not if the view selection fails. I added some code to re-connect
there and commited this.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an impetuous native American romance novelist on the edge. She's a 
mistrustful out-of-work cab driver who can talk to animals. They fight crime!