Re: [PATCH] Remove gtk-delete icon from delete confirmation alerts

[Alexander Larsson <alexl redhat com>]

On Mon, 2006-02-13 at 12:22 +0100, Luca Ferretti wrote:
> Il giorno lun, 13/02/2006 alle 10.30 +0100, Alexander Larsson ha
> scritto:
> > On Thu, 2006-02-09 at 09:22 +0100, Luca Ferretti wrote:
> > > I prepared the attached patch for bug # 325945 [1]: following inputs
> > > from Calum Benson and Matthias Clasen on theme list, by now the best way
> > > to solve this issue should be:
> > > 
> > >      1. remove the GTK_STOCK_DELETE icon from confirmation alerts for
> > >         delete actions (reason: currently we have no good icon for
> > >         delete)
> > >      2. switch to "gnome-fs-trash-[empty|full]" named icon in "Move to
> > >         Trash" menu entries (reason: use trash icon in move to trash
> > >         action)
> > > 
> > > Unfortunately it seems that gnome-fs-trash-* is non showed in menus at
> > > runtime... Any idea?
> > 
> > I think you need to add it to register_icons() in src/nautilus-main.c.
> 
> You are right, but this bring up another issue.
> 
> I've added gnome-fs-trash-full to register_icons() in
> icons_to_register[], recompiled and installed. Now the trash full icon
> is showed near the "Move to Trash" label in popup menu.
> 
> Unfortunately, changing icon theme (for example from "GNOME" to
> "Tango"), this icon is not updated (GNOME trash is blue, Tango is
> green): I've to kill nautilus. 

This is unfortunate. It probably happens for the other registered icons
too...

> PS do we really have to register named icons ?

I don't know any other way to get icons from the icon theme to work in
menus etc.

> PPS do you think I can propose the attached patch to release team for
> 2.14?

While the patch seems ok I'm not sure this is really important enough to
break the freeze.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a deeply religious dishevelled filmmaker haunted by memories of 'Nam. 
She's a foxy antique-collecting barmaid from Mars. They fight crime!