While we treat the margins of the icon container in canvas units, we set them in pixel units. Use a big panel and you'll note that it overlaps the icons on the top, as reported by bug 149847 [1]. Proposed patch attached. [1] http://bugzilla.gnome.org/show_bug.cgi?id=149847 -- Christian Neumair <chris gnome-de org>
Index: libnautilus-private/nautilus-icon-container.c =================================================================== RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-icon-container.c,v retrieving revision 1.397 diff -u -p -r1.397 nautilus-icon-container.c --- libnautilus-private/nautilus-icon-container.c 19 Sep 2005 09:59:50 -0000 1.397 +++ libnautilus-private/nautilus-icon-container.c 30 Sep 2005 09:25:30 -0000 @@ -6627,10 +6620,10 @@ nautilus_icon_container_set_margins (Nau { g_return_if_fail (NAUTILUS_IS_ICON_CONTAINER (container)); - container->details->left_margin = left_margin; - container->details->right_margin = right_margin; - container->details->top_margin = top_margin; - container->details->bottom_margin = bottom_margin; + container->details->left_margin = left_margin / EEL_CANVAS (container)->pixels_per_unit; + container->details->right_margin = right_margin / EEL_CANVAS (container)->pixels_per_unit; + container->details->top_margin = top_margin / EEL_CANVAS (container)->pixels_per_unit; + container->details->bottom_margin = bottom_margin / EEL_CANVAS (container)->pixels_per_unit; /* redo layout of icons as the margins have changed */ schedule_redo_layout (container);
Attachment:
signature.asc
Description: This is a digitally signed message part