Re: [PATCH] Fix crasher + leak when specifying domain in connect server dialog

Am Mittwoch, den 14.09.2005, 11:12 +0200 schrieb Christian Neumair:
> Am Mittwoch, den 14.09.2005, 01:21 +0200 schrieb Christian Neumair:
> > The attached patch fixes bug 314730 [1] and a potential leak, since the
> > user variable was not freed if the preceding if branch wasn't reached.
> > Also, passing free'd pointers to g_strconcat is no good.
> > 
> > Sidenote: According to the GnomeVFS SMB-Method code, the domain/user
> > will be figured out correctly even if user is "".
> By 'if user is ""' I mean the value of the user entry.
> The last patch potentially introduced a new crasher variant by always
> freeing the previous user variable.
> New patch attached.
> > [1]

Note that the potential crasher was only hypothetical, in practice the
user entry is always be visible if the domain entry is.

Christian Neumair <chris gnome-de org>

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]