Re: Polishing the icon stretching code

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-10-27 at 14:51 -0400, Matthias Clasen wrote:
> On Mon, 2005-10-24 at 13:21 -0400, Matthias Clasen wrote:
> > On Mon, 2005-10-24 at 09:27 +0200, Alexander Larsson wrote:
> > > On Sat, 2005-10-22 at 01:33 -0400, Matthias Clasen wrote:
> > > > I have attached a patch to
> > > > http://bugzilla.gnome.org/show_bug.cgi?id=157271
> > > > which makes nautilus use the resize cursors when stretching 
> > > > an icon. It also makes the knob image themable. 
> > > > 
> > > > There are some more things which could be improved here:
> > > > 
> > > >  - Add keynav for stretching icons (proposal: use Ctrl-+/-  to
> > > >    stretch the icon while the stretch handles are displayed)
> > > >  - Don't hardcode a line width of 1 for the focus-like rectangle
> > > >    drawn with the stretch handles, but use a value derived from
> > > >    focus-width.
> > > > 
> > > >  I also note that "note-indicator.png" is another icon that should
> > > >  probably be made themable.
> > > 
> > > Looks good to commit to HEAD.
> > 
> > I attched another iteration of the patch, which adds keynav
> > (C-+/C--/C-0 for growing, shrinking, or resetting) the icon which 
> > is currently stretched. I also changed the drawing code to draw the 
> > outline as black/white instead of black-over-background, since the
> > latter tends to be poorly visible on a dark background image.
> 
> Alex pointed out that Ctrl-0 did not actually work for unstretching.
> It took me a little while to figure out that it is because the 
> zoom_to_normal action is made invisible, but not insensitive like 
> the other zoom controls. Here is a patch which fixes this, and also
> makes C-= works in the same way as C-+ (nautilus also does this for the
> zoom controls).

Looks good. Please commit.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a jaded neurotic cowboy living undercover at Ringling Bros. Circus. She's 
a psychotic belly-dancing angel trying to make a difference in a man's world. 
They fight crime!