Re: [PATCH] Don't display authentication windows again if cancelled

[Alexander Larsson <alexl redhat com>]

On Wed, 2005-10-19 at 21:08 +0200, Christian Neumair wrote:
> Am Mittwoch, den 19.10.2005, 14:50 +0200 schrieb Alexander Larsson:
> > On Fri, 2005-10-07 at 20:53 +0200, Christian Neumair wrote:
> > > Together with [1] this patch ensures that authentication windows are not
> > > shown again if they're cancelled.
> > 
> >          if (vfs_result_code == GNOME_VFS_OK
> >              || vfs_result_code == GNOME_VFS_ERROR_NOT_SUPPORTED
> > -            || vfs_result_code == GNOME_VFS_ERROR_INVALID_URI) {
> > +            || vfs_result_code == GNOME_VFS_ERROR_INVALID_URI
> > +	    || vfs_result_code != GNOME_VFS_ERROR_CANCELLED) {
> > 
> > This part looks wrong (if result is a, b, or c, or result is anything
> > but cancelled, the last bit overrides the first). I don't think its
> > needed at all, is it?
> 
> Yes, you are right. Dunno how this crap made it into the patch.
> Reattaching new version, which doesn't have it.

Looks good. Please commit.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a deeply religious one-eyed astronaut who must take medication to keep 
him sane. She's a manipulative renegade soap star who believes she is the 
reincarnation of an ancient Egyptian queen. They fight crime!