Re: [PATCH] Don't break keynav after deletion failed
- From: Alexander Larsson <alexl redhat com>
- To: Christian Neumair <chris gnome-de org>
- Cc: nautilus-list gnome org
- Subject: Re: [PATCH] Don't break keynav after deletion failed
- Date: Wed, 19 Oct 2005 16:38:51 +0200
On Thu, 2005-10-13 at 13:09 +0200, Christian Neumair wrote:
> We have means in FMDirectoryView to prevent multiple deletions from
> being triggered while another still hasn't finished, which is
> implemented using the selection_was_removed flag. This flag isn't reset
> after deletion if the selection doesn't change, which is the case if the
> deletion failed.
>
> Proposed patch attached which fixes bug 318723 [1].
That is a very strange place to add that. It doesn't help the delete
case, only move to trash, and even then it catches all moves that result
in no emission of add_file before the gnome-vfs callback is called,
which i expect is most moves.
Unfortunately there is really no good place to hook into failure of the
delete operation. Maybe we should just do it in a timeout?
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a hate-fuelled overambitious paramedic on the hunt for the last specimen
of a great and near-mythical creature. She's a manipulative junkie wrestler
with a birthmark shaped like Liberty's torch. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]