Re: [PATCH] Fix list model reordering problems
- From: Alexander Larsson <alexl redhat com>
- To: Christian Neumair <chris gnome-de org>
- Cc: nautilus-list gnome org
- Subject: Re: [PATCH] Fix list model reordering problems
- Date: Mon, 03 Oct 2005 10:49:07 +0200
On Sat, 2005-10-01 at 13:48 +0200, Christian Neumair wrote:
> We've had a few bug reports about list model crashers when changing the
> sort criterion, with expanded nested subdirectories. It turns out that
> the way gtk_tree_model_rows_reordered was invoked was only appropriate
> before we had path depths > 0.
>
> Proposed patch attached. I've decided to do an assert since looking up
> the iter really shouldn't fail.
You don't want any real code in an assert, because it can be
conditionally compiled out. Otherwise this looks good, I moved the real
code out of the assert and commited.
I couldn't reproduce the crash before the fix though. I wonder why.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a one-legged gay stage actor from a doomed world. She's a pregnant
French-Canadian widow with a knack for trouble. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]