Re: [PATCH] - Fix for 155928 -Adds GTK2 Bookmarks to Nautilus

[Emmanuele Bassi <ebassi gmail com>]

hi,

On Tue, 2005-06-21 at 13:28 +0100, Jamie McCracken wrote:
> Luis Villa wrote:
> > FWIW, I believe the plan is for all of this to be ported to an API the
> > gtk folks actually believe should be public:
> > 
> > http://live.gnome.org/RecentFilesAndBookmarks
> > 
> 
> Will this be available in time for the next release (2.12)? .

Short answer: maybe.

Long answer: if I get around some rough edges, and put up my work in
libegg by next week, we can get some serious testing done before feature
freeze.

>  If a 
> library is already available now with bookmark support then yeah I can 
> redo my patch but as it appears to be dependant on changes in GTK File 
> Chooser it looks like thats some way off.

There already is a parser for desktop bookmarks, which will handle both
bookmarks and recently used files.  It's based on GLib and libxml2:

http://devel.emmanuelebassi.net/software/desktopbookmarks/

It's just a parser object, and assumes that you know the file format;
ideally, the FileChooser would use this object instead of the currently
used functions for reading/writing the .gtk-bookmarks file; then,
Gtk/Gnome would need a BookmarkManager object doing notification and
masking some of the API.

Once we decide a common name for the bookmarks file, both Gtk and
Nautilus could access the same data.  I won't go as far as saying that
Nautilus could use the new bookmarks format before Gtk does - since that
would be a bit off.

> Long term it does make sense to have a common api for the bookmarks but 
> as feature freeze is only a few weeks away I'll leave it to Alex to decide.

I agree with you; anyway, this code would hit the next Gnome release
cycle (at most), so, in the end, we would have G12 with a bookmark
system and G14 with another one.  Personally, I'd think that if your
patch is ready and no one complains we should use it.

But you are right: it's up to Alex to decide.

Regards,
 Emmanuele.

-- 
Emmanuele Bassi <ebassi gmail com>
Web site: http://log.emmanuelebassi.net