Re: [PATCH] Enable keypad zoom accelerators

[Alexander Larsson <alexl redhat com>]

On Wed, 2005-07-06 at 14:04 +0200, Christian Neumair wrote:
> Am Mittwoch, den 06.07.2005, 11:46 +0200 schrieb Alexander Larsson:
> > On Sat, 2005-07-02 at 13:44 +0200, Christian Neumair wrote:
> > > Am Samstag, den 02.07.2005, 11:48 +0200 schrieb Christian Neumair:
> > > > From bug 309018 [1]:
> > > > 
> > > > "Ctrl+ and Ctrl- seem to work on the actual keyboard, but not on the
> > > > numeric keypad. This is with Ubuntu Hoary, Nautilus 2.10.0 and a Finnish
> > > > keyboard layout."
> > > > 
> > > > The attached patch fixes this.
> > > > 
> > > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=309018
> > > 
> > > OK, new version. I overlooked that ctrl-0 is already bound to 100% zoom.
> > 
> > This doesn't look right. Surely index 0 should be bound to ctrl-1, not
> > ctrl-shift-0.
> > 
> > computers begin indexing at 0, but humans start at 1.
> 
> Sorry, I messed up the patches. You already approved the patch "Add
> accelerators for views", although you commented here on it. The mail
> "Re: [PATCH] Enable keypad zoom accelerators" you replied to was meant
> to be a reply to "Add accelerators for views". Therefore, the 2nd
> version of this patch has been approved, while the (simple) keypad patch
> hasn't.
> 
> On the view accelerators: The issue here is that index is only 0 for a
> potential "Extra Viewer", whatever it is. I don't know of any such view,
> and the icon view is assigned the index 1, list view gets index 2.

Ah the extra viewer. That happens if the view currently in use is not
actually in the list of applicable views for that location. This happens
for instance when the view is set in the metadata for the location, but
the reason for that view being applicable to the location has changed
(for instance, maybe you deleted all the files of the type it handled
from the folder). The extra viewer has to be added to the menu so we can
check it as being the active one.

I think you should just ignore index 0 and not have an accelerator for
the extra view.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a world-famous hunchbacked sorceror who must take medication to keep him 
sane. She's a supernatural mutant angel who hides her beauty behind a pair of 
thick-framed spectacles. They fight crime!