Re: [PATCH] Add Pathbar to Nautilus Browser

Alexander Larsson wrote:

First a bit on the general UI. I don't want to have the pathbar in
addition to the location bar, I want it to replace the location bar. For
a long time a major goal of nautilus has been to avoid displaying
pathnames (as in absolute pathnames or uris) in the UI. Going from
location bar will help with this. It will also help us look less like a
web browser, which is nice, as that can confuse people at times.

Of course, we can't totally remove the location bar, as its needed for
typing in addresses, and some people still might want it. What we'll do
is put the path bar and the location bar in the same place, but only
show one at a time. Normally we show the pathbar, but on "go ->
Location" in the menu (or ctrl+l) we temporarily show the location bar,
similarly to how this is handled when the location bar is not visible.

Lets also add a preference (hidden for the moment) to allow people to
always have the location bar instead of the pathbar.

Okay I will do that with Ctrl+L to toggle between pathbar and location bar. I'll leave the view->location bar menu item then so if they set it it toggles off the pathbar and permenantly replaces it (IE we dont need another pref then as I have added view->pathbar pref/menuitem already).

Comments about the code:

strings are not translated

It doesn't handle the desktop-is-home preference

file_path_exists does synchronous i/o, which is a no-no in nautilus. Why
do you have to check for the file existance here?

cause the file chooser does? I will scrap it then

The root icon for non file:/// uris is always a folder (I think). It
should use the real icon that nautilus uses for it, i.e. gotten from
nautilus_icon_factory_get_icon_for_file(). See for instance the location
menu in spatial mode that uses this and what icon it uses for

but its okay to hard code the icons for the common ones (home, desktop, filesystem) like the filechooser? I will just use icon_factory for the root folder then.

We should really re-root for all volumes too, not only the homedir. This
means you won't see /mnt/media/cdrom, but only
  [{cdicon} cdrom name][folder1][folder2]
Maybe we can wait a bit with implementing this so that we can get
something in first, but this would be really nice.

okay I'll put that on the back burner

The gtk+ pathbar code you used isn't the latest version. Gtk+ HEAD has a
different behaviour, primary wrt rerooting. It:
* only re-roots to the desktop
* allows you to scroll left when things are re-rooted
We should update the code to this version.

will update

Why did you add folder icons to normal folders? That seems to use a lot
of space for something that isn't really needed.

it looks nicer, improves usability (user can see they are folders instead of plain buttons) and thunar does so. Do you want me to remove them for now?


Mr Jamie McCracken

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]