Patch for some leaks in nautilus



Hi.

I've been running with the below patch for some time now with no ill
effects. Please review.

Cheers
Kjartan

? depcomp
? nautilus-folder-handler.desktop
? stamp-h1
Index: src/nautilus-notes-viewer.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-notes-viewer.c,v
retrieving revision 1.8
diff -u -p -r1.8 nautilus-notes-viewer.c
--- src/nautilus-notes-viewer.c	28 Jun 2005 12:54:45 -0000	1.8
+++ src/nautilus-notes-viewer.c	5 Jul 2005 07:27:45 -0000
@@ -489,6 +489,7 @@ get_property_pages (NautilusPropertyPage
         uri = nautilus_file_info_get_uri (file);
 	
 	viewer = g_object_new (nautilus_notes_viewer_get_type (), NULL);
+        g_free (viewer->details->uri);
         viewer->details->uri = uri;
         notes_load_metainfo (viewer);
 
Index: src/nautilus-property-browser.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-property-browser.c,v
retrieving revision 1.209
diff -u -p -r1.209 nautilus-property-browser.c
--- src/nautilus-property-browser.c	4 Apr 2005 19:30:22 -0000	1.209
+++ src/nautilus-property-browser.c	5 Jul 2005 07:27:46 -0000
@@ -1347,6 +1347,7 @@ emblem_dialog_clicked (GtkWidget *dialog
 						       stripped_keyword,
 						       stripped_keyword,
 						       GTK_WINDOW (property_browser));
+		g_object_unref (pixbuf);
 
 		nautilus_emblem_refresh_list ();
 		
@@ -1728,6 +1729,7 @@ make_properties_from_directories (Nautil
 		object_pixbuf = gdk_pixbuf_new_from_file (path, NULL);
 		g_free (path);
 		property_image = labeled_image_new (_("Erase"), object_pixbuf, "erase", PANGO_SCALE_LARGE);
+		g_object_unref (object_pixbuf);
 		eel_labeled_image_set_fixed_image_height (EEL_LABELED_IMAGE (property_image), MAX_EMBLEM_HEIGHT);
 
 		gtk_container_add (GTK_CONTAINER (image_table), property_image);
Index: src/nautilus-spatial-window.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-spatial-window.c,v
retrieving revision 1.445
diff -u -p -r1.445 nautilus-spatial-window.c
--- src/nautilus-spatial-window.c	23 Jun 2005 14:16:58 -0000	1.445
+++ src/nautilus-spatial-window.c	5 Jul 2005 07:27:46 -0000
@@ -716,6 +716,7 @@ nautilus_spatial_window_set_location_but
 			if (icon_name) {
 				gtk_image_set_from_icon_name (GTK_IMAGE (window->details->location_icon), 
 							      icon_name, GTK_ICON_SIZE_MENU);
+				g_free (icon_name);
 			} else {
 				gtk_image_set_from_stock (GTK_IMAGE (window->details->location_icon),
 							  GTK_STOCK_OPEN, GTK_ICON_SIZE_MENU);
Index: src/file-manager/fm-tree-view.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/fm-tree-view.c,v
retrieving revision 1.14
diff -u -p -r1.14 fm-tree-view.c
--- src/file-manager/fm-tree-view.c	1 Jul 2005 14:13:49 -0000	1.14
+++ src/file-manager/fm-tree-view.c	5 Jul 2005 07:27:46 -0000
@@ -160,7 +160,10 @@ show_iter_for_file (FMTreeView *view, Na
 		if (gtk_tree_model_get_iter (model, &cur_iter, path)) {
 			if (fm_tree_model_file_get_iter (view->details->child_model,
 							       iter, file, &cur_iter)) {
+				gtk_tree_path_free (path);
 				return TRUE;
+			} else {
+				gtk_tree_path_free (path);
 			}
 		}
 	}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]