Re: Warning on empty trash [was Re: feature freeze]

[Dennis Cranston <dennis_cranston yahoo com>]

I should have made it a two line patch.  The updated patch is attached.

--- Dennis Cranston <dennis_cranston yahoo com> wrote:

> An unrelated email posted to this list by Jorn reminded me of another problem with the new empty
> trash dialog.  The window title should not be "Warning".  I am attaching the one line fix.  
> Thanks.
> 
> 
> --- Alexander Larsson <alexl redhat com> wrote:
> 
> > On Mon, 2005-01-24 at 08:52 -0800, Dennis Cranston wrote:
> > 
> > > One verbage fix is needed.  In the secondary text the word "sepately" should be
> "separately". 
> > > Also, you might want to send a patch to the maintainers of the trash applet.  They use a
> > similar
> > > dialog.
> > 
> > Good catch.
> > 
> > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> >  Alexander Larsson                                            Red Hat, Inc 
> >                    alexl redhat com    alla lysator liu se 
> > He's a benighted gay cowboy trapped in a world he never made. She's a 
> > sarcastic renegade bodyguard looking for love in all the wrong places. They 
> > fight crime! 
> > 
> > -- 
> > nautilus-list mailing list
> > nautilus-list gnome org
> > http://mail.gnome.org/mailman/listinfo/nautilus-list
> > > Index: nautilus-file-operations.c
> ===================================================================
> RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-file-operations.c,v
> retrieving revision 1.182
> diff -u -p -r1.182 nautilus-file-operations.c
> --- nautilus-file-operations.c	25 Jan 2005 09:21:30 -0000	1.182
> +++ nautilus-file-operations.c	26 Jan 2005 17:14:37 -0000
> @@ -2569,6 +2569,7 @@ confirm_empty_trash (GtkWidget *parent_v
>  						    "you can also delete them "
>  						    "separately."));
>  
> +	gtk_window_set_title (GTK_WINDOW (dialog), ""); /* as per HIG */
>  	gtk_window_set_screen (GTK_WINDOW (dialog), screen);
>  	atk_object_set_role (gtk_widget_get_accessible (dialog), ATK_ROLE_ALERT);
>  	gtk_window_set_wmclass (GTK_WINDOW (dialog), "empty_trash",
> > -- 
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list
>

Index: nautilus-file-operations.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-file-operations.c,v
retrieving revision 1.183
diff -u -p -r1.183 nautilus-file-operations.c
--- nautilus-file-operations.c	26 Jan 2005 12:25:57 -0000	1.183
+++ nautilus-file-operations.c	27 Jan 2005 01:39:40 -0000
@@ -2569,6 +2569,8 @@ confirm_empty_trash (GtkWidget *parent_v
 						    "you can also delete them "
 						    "separately."));
 
+	gtk_window_set_title (GTK_WINDOW (dialog), ""); /* as per HIG */
+	gtk_window_set_skip_taskbar_hint (GTK_WINDOW (dialog), TRUE);
 	gtk_window_set_screen (GTK_WINDOW (dialog), screen);
 	atk_object_set_role (gtk_widget_get_accessible (dialog), ATK_ROLE_ALERT);
 	gtk_window_set_wmclass (GTK_WINDOW (dialog), "empty_trash",