Re: [PATCH] Move custom icons when copying metadata



On Sun, 2005-12-18 at 22:45 +0100, Christian Neumair wrote:
> On Mo, 2005-09-26 at 12:28 +0200, Alexander Larsson wrote:
> > Its sort of strange that the metafile system special-cases a specific
> > key entry like this. It would make more sense to e.g. store the custom
> > icon with a relative filename. That would work for more cases than the
> > prefix of the uri being identical too. For instance when there are
> > symlinks etc involved.
> 
> Do you prefer the attached patch?

Yeah that looks better.

 			if (nautilus_file_is_mime_type (file, "application/x-desktop")) {
+				icon = g_strdup (icon_path);
+

This seems to leak though.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an underprivileged shark-wrestling gangster with a secret. She's a 
time-travelling impetuous detective with the soul of a mighty warrior. They 
fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]