Re: [PATCH] Fix shift-select in manual icon layout mode



On Fri, 2005-08-26 at 23:15 +0200, Christian Neumair wrote:
> Am Freitag, den 15.07.2005, 11:40 +0200 schrieb Alexander Larsson:
> > 
> > Its still extremely weird. It allows 25 pixel above the highest icon,
> > but only the top 25 pixels of the lowest icon. Just either use the full
> > extent of both icons to calculate the max/min position, or use the
> > middle of the icon.
> 
> New proposed patch which takes into account the center of all selection
> candidates. I also tried to only use the image rectangle but throwed
> away this idea since it proved to feel a bit weird.

That patch seems to contain a variety of changes. Some are even partial,
so that the patch doesn't compile.

Also, by now we should be looking at showstopper bugs, like crashes or
data-loss things. While this bug is silly, and we should eventually fix
it, we shouldn't focus on it much atm.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a suicidal one-eyed sorceror fleeing from a secret government programme. 
She's a green-fingered impetuous mermaid with a flame-thrower. They fight 
crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]