Re: [PATCH] Jump To button in bookmark dialog always open browers window
- From: Martin Wehner <martin wehner gmail com>
- To: Jaap Haitsma <jaap haitsma org>
- Cc: "nautilus-list gnome org" <nautilus-list gnome org>
- Subject: Re: [PATCH] Jump To button in bookmark dialog always open browers window
- Date: Fri, 05 Aug 2005 23:37:47 +0200
On Tue, 2005-08-02 at 22:46 +0200, Jaap Haitsma wrote:
> Hi,
>
> Bugzilla entry is here [1]. The patch also does not show some critical
> messages like these
> ** (nautilus:16176): CRITICAL **: nautilus_view_factory_register: assertion
> `nautilus_view_factory_lookup (view_info->id) == NULL' failed
>
> which the original code had when the window that opened the bookmarks
> window was closed before hitting the "jump to" button. This was caused
> by the call to nautilus_application_new() in that code
Nice work. I cleaned up some style guide issues (always use brackets,
declare all local variables at the start of the function) and committed
it.
Thanks,
Martin
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]