Re: open() and cancellation - #123472

[Frederic Crozat <fcrozat mandriva com>]

Le lundi 01 août 2005 à 18:33 -0500, Federico Mena Quintero a écrit :
> Hi,
> 
> Bug #123472 has been biting us here at Novell because people mount
> netware filesystems (!) and Nautilus leaks file handles.  It does this
> while opening and reading text files to generate icons for them.
> 
> I just submitted a patch to bugzilla.  It patches file-method.c.
> 
> Although the bug report mentions that handles may be leaked for any
> method which does not handle cancellation on its own, I think
> file-method is by far the most important.
> 
> Does the patch seem reasonable?  It certainly fixes the problem with
> text files for me.

This patch should be sent to gnome-vfs mailing list, I think :)

BTW, it looks fine for me, I've just added it to Mandriva gnome-vfs2
package :)
-- 
Frederic Crozat <fcrozat mandriva com>
Mandriva