Hey everyone, This patch fixes 2 problems in the behavior of revealing selections in Nautilus list view: 1. If you select a file name in the middle of a long list, and then press 'f2' to rename the file, the selection will scroll to the top of the view. This disorients the user. The solution: fm-list-view.c: (fm_list_view_start_renaming_file) in the call to gtk_tree_view_scroll_to_cell, make the 4th argument FALSE, so that the tree view only scrolls when the selection is not visible. 2. If you press 'alt-up' in a spatial window, and the parent window is already open, the new selection will be scrolled to the top of the view, whether or not it was already visible. If the selection was already visible, then no scrolling should have been necessary. The solution: fm-list-view.c: (fm_list_view_reveal_selection) Manually call gtk_tree_view_scroll_to_cell with the 4th argument equal to FALSE, instead of calling fm_list_view_scroll_to_file. We want to preserve *_scroll_to_file's current behavior of always scrolling the selection to the top because it's the desired behavior for *_scroll_to_file, as documented in nautilus-icon-container.c (nautilus_icon_container_scroll_to_icon). Jimmy
Attachment:
list-view-reveal-selection.patch
Description: Binary data