Re: [PATCH] Bug 142227: alt-up should select folder in parent window



On Tue, 19 Oct 2004 15:55:18 +0200, Alexander Larsson <alexl redhat com> wrote:
> > fm-directory-view.c (selection_changed_callback)
> >       - reveal a new selection if it's set while the view is not loading
> 
> The patch in general looks good. I'm not sure I like this part though.
> Is scrolling to the first selected item the best thing to do every time
> the selection is changed from the shell? I don't think so. Better to
> just do it in the cases where we know we want to.

Ok, that makes sense. How about this solution: Since we need to reveal
the selection from nautilus-application.c
(nautilus_application_present_spatial_window_with_selection), I'm
thinking of creating a new function in nautilus-view-frame.c called
'nautilus_view_frame_reveal_selection'. So when a window is already
open, we call nautilus_view_frame_selection_changed() and then
nautilus_view_frame_reveal_selection() to reveal the new selection.
Sound like a good idea?

Jimmy



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]