Re: [PATCH] bug 154088 - Label background for select icons is not aligned with text
- From: Vincent Noel <vincent noel gmail com>
- To: Alexander Larsson <alexl redhat com>
- Cc: Martin Wehner <martin wehner epost de>, Nautilus <nautilus-list gnome org>
- Subject: Re: [PATCH] bug 154088 - Label background for select icons is not aligned with text
- Date: Wed, 6 Oct 2004 11:10:23 -0400
Actually the alignment changes if hinting is enabled/disabled for
freetype fonts. I have reopened bug 154088 and added a few comments...
I'm looking for a generic solution to this.
Cheers
Vincent
On Wed, 06 Oct 2004 16:50:43 +0200, Alexander Larsson <alexl redhat com> wrote:
> On Wed, 2004-10-06 at 09:24 +0200, Martin Wehner wrote:
> > On Fri, 2004-10-01 at 13:52 +0200, Alexander Larsson wrote:
> > > On Wed, 2004-09-29 at 18:40 -0400, Vincent Noel wrote:
> > > > Attached is a patch to fix the misalignment between an icon label its
> > > > background when the icon is selected.
> > > >
> > > > Before/after shots showing icon alignment can be found at
> > > > http://bugzilla.gnome.org/attachment.cgi?id=32082&action=view (before)
> > > > http://bugzilla.gnome.org/attachment.cgi?id=32091&action=view (after)
> > >
> > > Sweet! I commited this.
> >
> > Unfortunately this patch broke the label alignment for me: Labels are
> > now vertically misaligned in all zoom levels (like in the "before"
> > screeny but shifted to the top) but were aligned correctly before the
> > patch.
> >
> > http://bugzilla.gnome.org/attachment.cgi?id=32272&action=view
>
> Ah. Then this is likely a rounding issue depending on the exact size of
> the font or something like that.
>
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Alexander Larsson Red Hat, Inc
> alexl redhat com alla lysator liu se
> He's a bookish hunchbacked farmboy with a secret. She's a plucky winged soap
> star with the power to bend men's minds. They fight crime!
>
> --
> nautilus-list mailing list
> nautilus-list gnome org
> http://mail.gnome.org/mailman/listinfo/nautilus-list
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]