Re: nautilus crashes on upgrade fc2->fc3 in gnome 2.8



On Mon, 2004-11-22 at 23:21 +0100, Martin Wehner wrote:
> On Mon, 2004-11-22 at 22:40 +0100, Martin Wehner wrote:
> > /* We try to use the drive name to get somewhat stable filenames
> >    for metadata */
> > drive = gnome_vfs_volume_get_drive (volume);
> > if (drive != NULL) {
> > 	name = gnome_vfs_drive_get_display_name (drive);
> > } else {
> > 	name = gnome_vfs_volume_get_display_name (volume);
> > }
> > gnome_vfs_drive_unref (drive);
> > link->details->filename = g_strconcat (name, ".volume", NULL);
> 
> It looks like it wouldn't work for two volumes on the same drive
> either.. What does using the disk name buy you here?

Alex,

could you have a look at this? With 24 duplicates, it's the undisputed
top crasher of the 2.8.x series.
I'd say let's remove the usage of the drive name altogether, because
you'd have to jump through hoops to guarantee the uniqueness of the
desktop link filename at this point.
What do you think?

Martin





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]