Re: [PATCH] too much space between columns of icons on desktop

[Alexander Larsson <alexl redhat com>]

On Tue, 2004-11-02 at 21:03 -0800, Jimmy Do wrote:
> Hi everyone,
> 
> This patch fixes a bug in the way that the NautilusIconContainer
> places icons on the desktop grid. If you have a clean desktop with
> only a few icons, try pressing 'Shift-Control-N' to create lots of
> folders until you have multiple columns of them on your desktop.
> You'll notice that the spacing between the columns of icons seems
> unusually wide. If you try selecting an entire column (other than the
> left-most column) and dragging it slightly over to the left, you'll
> see that the entire column can comfortably snap into a position closer
> to the column on its left.
> 
> A bug in canvas_position_to_grid_position in nautilus-icon-container.c
> is what's causing columns to skip a grid position. When calculating
> grid_position->x1 and grid_position->y1, we need to take the floor,
> not the ceiling, of the result. Taking the ceiling caused us to
> include additional grid positions that the icon did not actually
> occupy.
> 
> Overview of Changes:
> nautilus-icon-container.c
> 	canvas_position_to_grid_position ():
> 		- removed some comments that did not reflect actual behavior
> 		- in calculating grid_position->x1 & ->y1 do 'floor' instead of 'ceil'
> 

Commited. Thanks.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a notorious crooked Green Beret who hides his scarred face behind a mask. 
She's an orphaned Buddhist socialite with the power to bend men's minds. They 
fight crime!