PATCH: logic errors in nautilus-plus-deps-for-tinderbox (so I am told)
- From: Telsa Gwynne <hobbit aloss ukuu org uk>
- To: nautilus-list gnome org
- Cc: davej redhat com
- Subject: PATCH: logic errors in nautilus-plus-deps-for-tinderbox (so I am told)
- Date: Thu, 8 Jan 2004 18:16:02 +0000
I am not sure how I ended up sending this, but attached is a patch
Dave J (CC'd) assures me is "logic errors" to be tidied up.
Telsa
--- gnome/./nautilus-plus-deps-for-tinderbox/bonobo/bonobo/bonobo-property-bag.c~ 2004-01-08 17:18:16.000000000 +0000
+++ gnome/./nautilus-plus-deps-for-tinderbox/bonobo/bonobo/bonobo-property-bag.c 2004-01-08 17:18:28.000000000 +0000
@@ -486,10 +486,10 @@
{
BonoboPropertyFlags f = 0;
- if (!flags & GTK_ARG_READABLE)
+ if (!(flags & GTK_ARG_READABLE))
f |= BONOBO_PROPERTY_READABLE;
- if (!flags & GTK_ARG_WRITABLE)
+ if (!(flags & GTK_ARG_WRITABLE))
f |= BONOBO_PROPERTY_WRITEABLE;
return f;
--- gnome/./nautilus-plus-deps-for-tinderbox/bonobo/libefs/src/efs.c~ 2004-01-08 17:18:35.000000000 +0000
+++ gnome/./nautilus-plus-deps-for-tinderbox/bonobo/libefs/src/efs.c 2004-01-08 17:18:40.000000000 +0000
@@ -201,7 +201,7 @@
if (!(driver = efs_find_driver(drivername)))
return EFS_ERR_NODRIVER;
- if (head->protected & !pw) {
+ if (head->protected && !pw) {
if (!pass_func) return EFS_ERR_INVPASS;
if (!(pw = pass_func (filename, FALSE)))
return EFS_ERR_INVPASS;
--- gnome/./nautilus-plus-deps-for-tinderbox/bonobo/libefs/src/mime.c~ 2004-01-08 17:18:45.000000000 +0000
+++ gnome/./nautilus-plus-deps-for-tinderbox/bonobo/libefs/src/mime.c 2004-01-08 17:19:11.000000000 +0000
@@ -214,8 +214,8 @@
gint32 l, l_le;
gchar *p;
- if (!efs->s2i_hash | !efs->i2s_hash) return 0;
- if (!efs->typefd) return 0;
+ if ((!efs->s2i_hash) || (!efs->i2s_hash)) return 0;
+ if (!(efs->typefd)) return 0;
code = FIRST_USER_TYPE + efs->tc++;
--- gnome/./nautilus-plus-deps-for-tinderbox/evolution/camel/providers/imap/camel-imap-store.c~ 2004-01-08 17:19:17.000000000 +0000
+++ gnome/./nautilus-plus-deps-for-tinderbox/evolution/camel/providers/imap/camel-imap-store.c 2004-01-08 17:19:26.000000000 +0000
@@ -1737,7 +1737,7 @@
if (!response) {
char *folder_real;
- if (!flags & CAMEL_STORE_FOLDER_CREATE) {
+ if (!(flags & CAMEL_STORE_FOLDER_CREATE)) {
CAMEL_SERVICE_UNLOCK (imap_store, connect_lock);
return no_such_folder (folder_name, ex);
}
--- gnome/./nautilus-plus-deps-for-tinderbox/evolution/camel/providers/imapp/camel-imapp-store.c~ 2004-01-08 17:19:36.000000000 +0000
+++ gnome/./nautilus-plus-deps-for-tinderbox/evolution/camel/providers/imapp/camel-imapp-store.c 2004-01-08 17:19:42.000000000 +0000
@@ -719,7 +719,7 @@
folder = camel_object_bag_get(store->folders, "INBOX");
if (folder) {
- /*if (!cflags & FAST)*/
+ /*if (!(cflags & FAST))*/
camel_imapp_driver_update(istore->driver, (CamelIMAPPFolder *)folder);
fi->unread_message_count = camel_folder_get_unread_message_count(folder);
camel_object_unref(folder);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]