Re: [PATCH] Scroll to first cell while renaming (bug#132785)



Hi Dave,

If I choose 0.5 for column alignment, column is not scrolled fully to
the left. So I used 1.0. For row alignment I used 0.0. 

I will commit the patch.

Thanks for the review.
Narayana

Dave Camp wrote:
> 
> Looks ok to commit, although the aligns should maybe be 0.0 and 0.5 ?
> 
> -dave
> 
> On Fri, 2004-02-20 at 10:43, Narayana Pattipati wrote:
> > Hi,
> >
> > I have uploaded a small patch to fix the following accessibility bug in
> > bugzilla:
> > http://bugzilla.gnome.org/show_bug.cgi?id=132785
> >
> > The patch makes treeview to scroll to the first column, when user
> > presses F2 to rename a file/folder in listview.
> >
> > Could you please review the patch.
> >
> > Thanks,
> > Narayana
> >
> > ______________________________________________________________________
> > --- nautilus/ChangeLog        Fri Feb 20 15:30:10 2004
> > +++ nautilus-new/ChangeLog    Fri Feb 20 05:03:54 2004
> > @@ -1,3 +1,9 @@
> > +2004-02-20  Narayana Pattipati  <narayana pattipati wipro com>
> > +
> > +     * src/file-manager/fm-list-view.c (fm_list_view_start_renaming_file):
> > +     Scroll to the particular column in listview while renaming. Fix
> > +     bugzilla bug# 132785
> > +
> >  2004-02-19  Alexander Larsson  <alexl redhat com>
> >
> >       * src/file-manager/fm-directory-view.c (file_list_all_are_folders):
> > --- nautilus/src/file-manager/fm-list-view.c  Fri Feb 20 15:31:15 2004
> > +++ nautilus-new/src/file-manager/fm-list-view.c      Fri Feb 20 15:29:52 2004
> > @@ -1808,6 +1808,10 @@ fm_list_view_start_renaming_file (FMDire
> >                     NULL);
> >
> >
> > +     gtk_tree_view_scroll_to_cell (list_view->details->tree_view,
> > +                                   path,
> > +                                   list_view->details->file_name_column,
> > +                                   TRUE, 1.0, 1.0);
> >       gtk_tree_view_set_cursor (list_view->details->tree_view,
> >                                 path,
> >                                 list_view->details->file_name_column,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]