Re: [PATCH] Crash renaming empty selection (#131861)



On Fri, 2004-02-06 at 19:22 -0800, Darin Adler wrote:  
> Shouldn't the nautilus_file_list_free (selection) line be outside the 
> if to avoid a storage leak?
> 
>      -- Darin

Hi Darin,

well I don't think it actually leaks anything because it only doesn't
free when selection == NULL. But in all other instances where
empty_selection() is used, file_list_free() is outside the if block and
called on potentially empty selections.
So I guess it should be outside in this instance too. Should I update it
accordingly?

Martin





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]