Re: [PATCH] Progress Crash (#148791)

[Alexander Larsson <alexl redhat com>]

On Sat, 2004-08-07 at 18:49, Martin Wehner wrote:
> In time_remaining_callback() transfer_rate can get 0, if the transfer
> stalls on a slow connection or if the user was asked about overwriting
> an existing file. Nautilus then bombs over a division by zero when
> calculating time_remaining.
> The way it is handled now, the time spend in gui callbacks (like the
> overwrite confirmation) counts towards the transfer time, because
> gnome_vfs has no progress field for "effective_transfer_time". So you
> have to use first_transfer_time, which really isn't what you are
> interested in most of the time.
> With this patch the progress dialog now shows nothing in place of the
> remaining time in this case, which is unfortunately the only sane thing
> we can do now until the progress calculation in gnome_vfs is enhanced.
> When it is, we could put "(Stalled)" or something in the progress dialog
> when transfer_rate approaches zero.

Looks good to commit.

> Please note that there's another progress related patch at #148690
> pending review.

I commited that.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an all-American vegetarian jungle king with a secret. She's a 
cold-hearted red-headed research scientist living on borrowed time. They fight 
crime!