Re: [PATCH] Fixed the defect 126887
- From: Dave Camp <dave ximian com>
- To: Srinivasa Ragavan <sragavan novell com>
- Cc: nautilus-list gnome org
- Subject: Re: [PATCH] Fixed the defect 126887
- Date: Mon, 17 Nov 2003 07:28:28 +0530
View failure is a valid failure condition (not a code bug) so it
shouldn't use g_return_if_fail(). Also, the parent function should
probably be called in this case.
On Mon, 2003-11-17 at 15:39, Srinivasa Ragavan wrote:
> I have fixed the defect 126887. The defect is, when a user double clicks
> a file on which he doesnt have read rights, it tries opening the file.
> The view fails. Nautilus was not able to handle the view failure. The
> fix was new_view is null, when view has failed. It wasnt handled.
> Patch is listed below.
> Index: nautilus/src//nautilus-navigation-window.c
> RCS file: /cvs/gnome/nautilus/src/nautilus-navigation-window.c,v
> retrieving revision 1.417
> diff -p -u -r1.417 nautilus-navigation-window.c
> --- nautilus/src//nautilus-navigation-window.c 3 Nov 2003 14:12:38
> -0000 1.417
> +++ nautilus/src//nautilus-navigation-window.c 17 Nov 2003 09:26:11
> @@ -944,6 +944,8 @@ real_set_content_view_widget (NautilusWi
> disconnect_view (window, nautilus_window->content_view);
> + g_return_if_fail(new_view != NULL);
> EEL_CALL_PARENT (NAUTILUS_WINDOW_CLASS,
> (nautilus_window, new_view));
] [Thread Prev