GNOME.org
 

Bug #112207 - HIG compliance, PATCH - Commit?

Bug #112207 is a simple fix, has a patch, and has been open for over a month.

Attached is another patch with the ChangeLog date updated.

Commit?



Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/nautilus/ChangeLog,v
retrieving revision 1.5832
diff -p -u -r1.5832 ChangeLog
--- ChangeLog	6 Jun 2003 17:09:03 -0000	1.5832
+++ ChangeLog	8 Jun 2003 04:49:53 -0000
@@ -1,3 +1,15 @@
+2003-06-08  Greg Merchan  <merchan phys lsu edu>
+	* libnautilus-private/nautilus-program-chooser.c,
+	  src/file-manager/fm-desktop-icon-view.c,
+	  src/nautilus-bookmarks-window.c,
+	  src/nautilus-property-browser.c,
+	  src/nautilus-window-menus.c,
+	  src/nautilus-window.c,
+	  src/nautilus-file-management-properties.c,
+	  src/nautilus-server-connect.c
+	Change GTK_BUTTONS_CLOSE to GTK_BUTTONS_OK for HIG compliance
+	Fixes bug 112207
+	
 2003-06-06  Samúel Jón Gunnarsson  <sammi techattack nu>
 
 	* configure.in: Added "is" into ALL_LINGUAS
Index: libnautilus-private/nautilus-program-chooser.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-program-chooser.c,v
retrieving revision 1.84
diff -p -u -r1.84 nautilus-program-chooser.c
--- libnautilus-private/nautilus-program-chooser.c	16 May 2003 08:36:51 -0000	1.84
+++ libnautilus-private/nautilus-program-chooser.c	8 Jun 2003 04:49:56 -0000
@@ -189,7 +189,7 @@ help_cb (GtkWidget *button, NautilusProg
 		err_dialog = gtk_message_dialog_new (GTK_WINDOW (program_chooser),
 						     GTK_DIALOG_MODAL,
 						     GTK_MESSAGE_ERROR,
-						     GTK_BUTTONS_CLOSE,
+						     GTK_BUTTONS_OK,
 						     _("There was an error displaying help: %s"),
 						     error->message);
 
Index: src/nautilus-bookmarks-window.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-bookmarks-window.c,v
retrieving revision 1.76
diff -p -u -r1.76 nautilus-bookmarks-window.c
--- src/nautilus-bookmarks-window.c	26 May 2003 13:15:28 -0000	1.76
+++ src/nautilus-bookmarks-window.c	8 Jun 2003 04:49:57 -0000
@@ -142,7 +142,7 @@ nautilus_bookmarks_window_response_callb
 			err_dialog = gtk_message_dialog_new (GTK_WINDOW (dialog),
 							     GTK_DIALOG_DESTROY_WITH_PARENT,
 							     GTK_MESSAGE_ERROR,
-							     GTK_BUTTONS_CLOSE,
+							     GTK_BUTTONS_OK,
 							     _("There was an error displaying help: \n%s"),
 							     error->message);
 
Index: src/nautilus-file-management-properties.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-file-management-properties.c,v
retrieving revision 1.6
diff -p -u -r1.6 nautilus-file-management-properties.c
--- src/nautilus-file-management-properties.c	17 Mar 2003 15:52:27 -0000	1.6
+++ src/nautilus-file-management-properties.c	8 Jun 2003 04:49:58 -0000
@@ -234,7 +234,7 @@ preferences_show_help (GtkWindow *parent
 		dialog = gtk_message_dialog_new (GTK_WINDOW (parent),
 						 GTK_DIALOG_DESTROY_WITH_PARENT,
 						 GTK_MESSAGE_ERROR,
-						 GTK_BUTTONS_CLOSE,
+						 GTK_BUTTONS_OK,
 						 _("There was an error displaying help: \n%s"),
 						 error->message);
 
Index: src/nautilus-property-browser.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-property-browser.c,v
retrieving revision 1.198
diff -p -u -r1.198 nautilus-property-browser.c
--- src/nautilus-property-browser.c	26 May 2003 14:07:23 -0000	1.198
+++ src/nautilus-property-browser.c	8 Jun 2003 04:50:00 -0000
@@ -1440,7 +1440,7 @@ help_button_callback (GtkWidget *widget,
 		dialog = gtk_message_dialog_new (GTK_WINDOW (property_browser),
 						 GTK_DIALOG_DESTROY_WITH_PARENT,
 						 GTK_MESSAGE_ERROR,
-						 GTK_BUTTONS_CLOSE,
+						 GTK_BUTTONS_OK,
 						 _("There was an error displaying help: \n%s"),
 						 error->message);
 
Index: src/nautilus-server-connect.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-server-connect.c,v
retrieving revision 1.6
diff -p -u -r1.6 nautilus-server-connect.c
--- src/nautilus-server-connect.c	16 Apr 2003 08:31:37 -0000	1.6
+++ src/nautilus-server-connect.c	8 Jun 2003 04:50:01 -0000
@@ -52,7 +52,7 @@ error (char *msg)
 	dialog = gtk_message_dialog_new (NULL,
 			0,
 			GTK_MESSAGE_ERROR,
-			GTK_BUTTONS_CLOSE,
+			GTK_BUTTONS_OK,
 			msg,
 			NULL);
 	gtk_dialog_run (GTK_DIALOG (dialog));
Index: src/nautilus-window-menus.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-window-menus.c,v
retrieving revision 1.261
diff -p -u -r1.261 nautilus-window-menus.c
--- src/nautilus-window-menus.c	5 May 2003 09:55:59 -0000	1.261
+++ src/nautilus-window-menus.c	8 Jun 2003 04:50:02 -0000
@@ -765,7 +765,7 @@ help_menu_nautilus_manual_callback (Bono
 		dialog = gtk_message_dialog_new (GTK_WINDOW (window),
 						 GTK_DIALOG_MODAL,
 						 GTK_MESSAGE_ERROR,
-						 GTK_BUTTONS_CLOSE,
+						 GTK_BUTTONS_OK,
 						 _("There was an error displaying help: \n%s"),
 						 error->message);
 		g_signal_connect (G_OBJECT (dialog), "response",
Index: src/nautilus-window.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-window.c,v
retrieving revision 1.412
diff -p -u -r1.412 nautilus-window.c
--- src/nautilus-window.c	23 Apr 2003 10:35:40 -0000	1.412
+++ src/nautilus-window.c	8 Jun 2003 04:50:04 -0000
@@ -1909,7 +1909,7 @@ nautilus_window_display_error (NautilusW
 	GtkWidget *dialog;
 	
 	dialog = gtk_message_dialog_new (GTK_WINDOW (window), 0, GTK_MESSAGE_ERROR,
-					 GTK_BUTTONS_CLOSE, error_msg, NULL);
+					 GTK_BUTTONS_OK, error_msg, NULL);
 	gtk_widget_show (dialog);
 }
 
Index: src/file-manager/fm-desktop-icon-view.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/file-manager/fm-desktop-icon-view.c,v
retrieving revision 1.204
diff -p -u -r1.204 fm-desktop-icon-view.c
--- src/file-manager/fm-desktop-icon-view.c	15 May 2003 17:19:26 -0000	1.204
+++ src/file-manager/fm-desktop-icon-view.c	8 Jun 2003 04:50:06 -0000
@@ -737,7 +737,7 @@ volume_ops_callback (BonoboUIComponent *
 			status = egg_screen_execute_command_line_async (screen, command, &error);
 			if (!status) {
 				dialog = gtk_message_dialog_new (NULL, 0,
-								 GTK_MESSAGE_ERROR, GTK_BUTTONS_CLOSE, 
+								 GTK_MESSAGE_ERROR, GTK_BUTTONS_OK, 
 								 _("Error executing utility program '%s': %s"), command, error->message);
 				g_signal_connect (G_OBJECT (dialog), "response", 
 						  G_CALLBACK (gtk_widget_destroy), NULL);
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]