Re: [PATCH] Fix for #120222 (Crash on duplicate mounts)

[Alexander Larsson <alexl redhat com>]

On Tue, 2003-12-02 at 01:40, Martin Wehner wrote:
> On Tue, 2003-12-02 at 00:07, Martin Wehner wrote:
> > This patch prevents Nautilus from crashing when a filesystem is mounted
> > multiple times with the same name and is listed in /etc/fstab (#120222).
> > 
> > Cheers,
> > Martin
> 
> Ok, that was too easy. Now it crashes at shutdown while trying to remove
> the same file multiple times. This could be cured by restructuring
> nautilus_directory_remove_file() a bit, but that's just another
> quick-fix so I'm reluctant to do so.
> I guess the real fix would be to make the volume manager sort these
> kinds of duplicate mounts out. Could someone more knowledgeable about
> the volume management comment on this?

Yeah, we should just remove duplicates early in the volume monitor.
update_fstab_drives() in gnome-vfs-volume-monitor-daemon.c seems like a
good spot.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an impetuous umbrella-wielding inventor gone bad. She's a wealthy 
motormouth hooker from aristocratic European stock. They fight crime!