[Nautilus-list] drag window focus hack issues



Hi,

nautilus-drag-window.c installs a client message filter for
WM_PROTOCOLS messages. There are several issues with this hack:

 - when it focuses a window, it sets focus to the 
   window itself not GTK's magic focus child window. 
   Not sure what impact this has.

 - when a window is not a registered drag window (e.g. prefs dialog),
   Nautilus client message filter never calls XSetInputFocus() at all
   which breaks Metacity.  It works with sawfish/twm/fvwm2 but I
   do not understand why - WM isn't supposed to set focus here 
   and Nautilus does not AFAICT.

   (This bug was introduced because GTK 2 sets "input = FALSE"
    meaning the window manager isn't supposed to be setting 
    focus to GTK windows, just asking the app to do so.)

 - it breaks GTK's _NET_WM_PING support.

On a random other note:
 
 - the XSetInputFocus() in eel-gdk-extensions should probably 
   use RevertToParent

Havoc





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]