[Nautilus-list] Re: [PATCH] more desktop==home fixes

[Darin Adler <darin bentspoon com>]

> +	    && !eel_preferences_get_boolean 
(NAUTILUS_PREFERENCES_DESKTOP_IS_HOME_DIR)) {

It seems wrong for nautilus_link_local_is_home_link to return false if 
the preference is true. That should be handled at a higher level. It's 
not like the home link becomes "not a home link" because of the 
preferences setting. In particular, this makes it so the home link 
doesn't get updated properly if the preference is off, which is not 
necessarily a good idea. You already made a change at the higher level 
to not re-create the home link if the preference is true.

It seems OK to have nautilus_link_local_is_special_link do this check, 
although I'd prefer a more-specific name that tells you what's special 
about these links (not deletable by the user, maybe?).

Otherwise, patch looks fine. Please commit.

    -- Darin