Re: [Nautilus-list] Patch for custom icon

[Darin Adler <darin bentspoon com>]

> -	exactly_one = uris[0] != NULL && uris[1] == NULL;
> +	exactly_one = uris[0] != NULL && *uris[1] == 0;

What about the case where uris[1] is NULL? I think you want

	exactly_one = uris[0] != NULL && (uris[1] == NULL || *uris[1] == 0);

No?

> +				gchar *escaped_name;

In Nautilus, we don't use gchar, and we put all declarations at the top 
of functions. See the Nautilus coding style guide in nautilus/doc for 
details.

> +				escaped_name = gnome_vfs_escape_host_and_path_string (uris[0]);

I'm not sure this is right. What if the URL is already escaped properly? 
Then don't we have a problem where "%" characters will get turned into 
"%25"?

> +		escaped_name = gnome_vfs_escape_host_and_path_string (icon_uri);

This should be completely unnecessary. The URI that you get from 
gnome_vfs_get_uri_from_local path shouldn't have any characters in it 
that need escaping. Can you give me an example of where this is 
necessary?

It's possible that I'm just misunderstanding what's going on here. It's 
also possible that this needs to be fixed at another level.

    -- Darin