Re: [Nautilus-list] [PATCH] makes the hide sidebar work

[Alex Larsson <alexl redhat com>]

On 3 Mar 2002, Diego González wrote:

> On sáb, 2002-03-02 at 21:38, Alex Larsson wrote:
> > On 2 Mar 2002, Diego González wrote:
> > 
> > > hi
> > > 
> > > 	This patch makes the sidebar to be completely hidden when selecting so
> > > from the preferences or from then menu.
> > 
> > Looks pretty good!
> > 
> > There are some issues though. You can easily get it "confused" by clicking 
> > on the splitter to collapse it, and then the view menu still says "hide 
> > sidebar", but selecting it expands the sidebar.
> > 
> > I think you should make splitter_hide() just hide the first child, and not 
> > mess with the position and saved position at all. Then you should export a 
> > new function nautilus_horizontal_splitter_is_hidden(), that returns if
> > if !(paned->child1 && GTK_WIDGET_VISIBLE (paned->child1)). Then use this 
> > function from nautilus_window_sidebar_showing.
> 
> here is my second try. This time it seems to work as it is supposed to.
> 
> i added a function _is_hidden and _show/_hide.

Applied, after removing the whitespace changes in nautilus-window-menus.c.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a genetically engineered dishevelled jungle king haunted by memories of 
'Nam. She's a cynical Bolivian wrestler with a song in her heart and a spring 
in her step. They fight crime!