Re: [Nautilus-list] [PATCH] makes the hide sidebar work

[Diego González <dggonz yahoo com>]

On sáb, 2002-03-02 at 21:38, Alex Larsson wrote:
> On 2 Mar 2002, Diego González wrote:
> 
> > hi
> > 
> > 	This patch makes the sidebar to be completely hidden when selecting so
> > from the preferences or from then menu.
> 
> Looks pretty good!
> 
> There are some issues though. You can easily get it "confused" by clicking 
> on the splitter to collapse it, and then the view menu still says "hide 
> sidebar", but selecting it expands the sidebar.

truth, i didn't make that check
> 
> I think you should make splitter_hide() just hide the first child, and not 
> mess with the position and saved position at all. Then you should export a 
> new function nautilus_horizontal_splitter_is_hidden(), that returns if
> if !(paned->child1 && GTK_WIDGET_VISIBLE (paned->child1)). Then use this 
> function from nautilus_window_sidebar_showing.

ok, i will do that.
> 
> I think that will work.
> 
> -- 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat, Inc 
>                    alexl redhat com    alla lysator liu se 
> He's a world-famous voodoo master criminal with no name. She's a supernatural 
> French-Canadian opera singer who hides her beauty behind a pair of 
> thick-framed spectacles. They fight crime! 
> 
> 
> _______________________________________________
> nautilus-list mailing list
> nautilus-list lists eazel com
> http://lists.eazel.com/mailman/listinfo/nautilus-list