Re: [Nautilus-list] [PATCH] removes the calls to gtk_timeout_add
- From: Alex Larsson <alexl redhat com>
- To: Diego González <dggonz yahoo com>
- Cc: Nautilus List <nautilus-list lists eazel com>
- Subject: Re: [Nautilus-list] [PATCH] removes the calls to gtk_timeout_add
- Date: Sat, 2 Mar 2002 15:50:49 -0500 (EST)
On 2 Mar 2002, Diego González wrote:
> hi
>
> this is a simple patch that substitutes all the calls to
> gtk_timeout_add and replaces them by g_timeout_add, i did this in the
> files in libnautilus-private, if you're interested in this kind of
> patches i can go all over the code.
They are not a really a priority, but since they are trivial to verify
correct (no semantic change) they are sort of interesting.
I see you only changed gtk_timeout_add. Perhaps you should change
gtk_timeout_remove to g_source_remove too. And when you do this you have
to change the indentation to be correct too.
For instance, in:
--- nautilus-drag-window.c 2002/02/25 23:16:39 1.12
+++ nautilus-drag-window.c 2002/03/02 17:59:16
@@ -160,7 +160,7 @@
if (details != NULL) {
remove_focus_timeout (window);
details->focus_timeout_tag
- = gtk_timeout_add (WINDOW_FOCUS_TIMEOUT,
+ = g_timeout_add (WINDOW_FOCUS_TIMEOUT,
focus_timeout_callback, window);
}
}
You need to reindent the line after gtk_timeout_add too.
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's a war-weary shark-wrestling astronaut on a search for his missing sister.
She's a sarcastic African-American magician's assistant with a flame-thrower.
They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]