Re: PATCH: use local path when dropping files onto icons
- From: Frank Worsley <fworsley shaw ca>
- To: Alexander Larsson <alexl redhat com>
- Cc: nautilus-list gnome org
- Subject: Re: PATCH: use local path when dropping files onto icons
- Date: Tue, 25 Jun 2002 00:12:14 -0700
> Looks good except for this:
> + } else if (uri != NULL
> + && nautilus_file_is_executable (file)
> + && nautilus_file_can_execute (file)
> + && nautilus_file_is_local (file)) {
>
> You can't use is_local here, since that means you can't start apps from
> NFS directories. (In fact, since it's completely unspecifed what is_local
> means i'd say any use of it is broken.) I'd hate to add another has_prefix
> ("file:") though, maybe we should add a
> EEL_VFS_TEST_IS_MOUNTED_FILESYSTEM to eel_vfs_test_capabilities.
I don't really know since I never used that eel stuff. ;)
But in this case I use gnome_vfs_get_local_path_from_uri anyway so I
guess it doesn't matter if the is_local test is removed.
I will remove the test and commit it, ok?
- Frank
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]