Re: [Nautilus-list] [PATCH] correct dates in nautilus

[Darin Adler <darin bentspoon com>]

On 1/19/02 10:02 AM, "Gediminas Paulauskas" <menesis delfi lt> wrote:

> This patch for eel makes all dates displayed correctly even in non-ascii
> locales. May I commit?

The idea of the patch is perfect.

I'm think we need to check and handle the case where the g_locale_from_utf8
call fails and returns NULL. I think we want to do a return_if_fail in that
case (and the g_string_new should be moved after).

Also, you need a new variable to hold the converted string. You can't just
use "remainder", because that gets moved along the string buffer as we walk.
So the g_free will just trash memory in many cases. So you should change
remainder back to a const char *, and create a char * variable called
format_in_locale_encoding or something like that.

Please fix those two things, and then show me a new patch so we can get it
in there.

    -- Darin