Re: [Nautilus-list] toolbar icons patch



On 2/20/02 5:49 AM, "Jens Finke" <jens triq net> wrote:

> this patch makes the up, back and forward toolbar icons work again if the
> theme doesn't provide custom icons (eg. with the gnome scheme).

That's great.

> For the standard up button it's enough to adapt the new gtk naming scheme.
> The setup function for special toolbar buttons (like back and forward)
> falls back to the gtk stock icons if the theme doesn't provide own icons.
> Unfourtunately this would require renaming the Back|Up|Forward.png theme
> images to Go-Back|Go-Up|Go-Forward.png. Again, this is to be compatible
> with the new gtk naming scheme.
> 
> Is it ok to commit the patch in this form?

I'm not really comfortable with the use of the deprecated g_strdown, and
prepending "gtk-".

Instead, lets just add a parameter to the set_up_bonobo_button functions for
the name of the stock icon to be used if an icon file can't be found.

OK?

    -- Darin





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]