Re: PATCH: use timeouts for progress dialogs
- From: Dave Camp <dave ximian com>
- To: Frank Worsley <fworsley shaw ca>
- Cc: nautilus-list gnome org, jdub perkypants org
- Subject: Re: PATCH: use timeouts for progress dialogs
- Date: 09 Aug 2002 23:44:17 -0400
This looks ok to commit (and without all the delaying of the creation,
is probably small enough to be ok for the 2.0.x branch)
-dave
On Mon, 2002-08-05 at 22:20, Frank Worsley wrote:
> > @@ -400,7 +436,10 @@ nautilus_file_operations_progress_new_fi
> > char *progress_count;
> >
> > g_return_if_fail (NAUTILUS_IS_FILE_OPERATIONS_PROGRESS
> > (progress));
> > - g_return_if_fail (GTK_WIDGET_REALIZED (progress));
> > +
> > + if (!GTK_WIDGET_REALIZED (progress)) {
> > + return;
> > + }
> >
> > Should this be here?
>
> I dunno, not sure why the return_if_fail was there in the first place.
> I've removed it.
>
> > Somewhere in here you should probably update start_time, in case a pause
> > happens twice before the timeout happens (it's not likely, but you
> > should probably take care of it anyway).
>
> Done. Also changed it so that start_time is first set when the timeout
> is created in _new(), not in _init().
>
> - Frank
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]