[Nautilus-list] Re: [GNOME VFS] start-here: etc. vfs method

[Ian McKellar <yakk eavel com>]

On Thu, Sep 20, 2001 at 03:27:29PM -0400, Havoc Pennington wrote:
> 
> Hi,
> 
> This is a bit overdue, my apologies. Anyhow, the patch is appended,
> against stable branch, though clearly it needs merging to HEAD as
> well.
> 
>  
> Index: modules/Makefile.am
> ===================================================================
> RCS file: /cvs/gnome/gnome-vfs/modules/Makefile.am,v
> retrieving revision 1.67.2.3
> diff -u -p -u -r1.67.2.3 Makefile.am
> --- modules/Makefile.am	2001/09/19 19:13:35	1.67.2.3
> +++ modules/Makefile.am	2001/09/20 19:29:00
> @@ -20,6 +20,7 @@ INCLUDES =					\
>  
>  EXTRA_DIST =					\
>  	default-modules.conf			\
> +	desktop-module.conf			\
>  	cdda-module.conf			\

(snip)

> -modulesconf_DATA = default-modules.conf $(CDDA_CONF) $(SSL_CONF)
> +modulesconf_DATA = default-modules.conf desktop-module.conf $(CDDA_CONF) $(SSL_CONF)
>  

Why do you have a separate conf file for this? Is it nececary?
>  
> Index: modules/desktop-method.c
> ===================================================================
(snip)
> +
> +#define G_N_ELEMENTS(arr)		(sizeof (arr) / sizeof ((arr)[0]))

Is this macro going to be in GLib2? If its not part of a glib I would
rather it not have it use the G_ prefix.

Other than that it looks good. Do you think you'll have a chance to make a
patch against HEAD too?

Thanks,

Ian