Re: [Nautilus-list] Text color in sidebar

[Kenny Graunke <kenny whitecape org>]

<quote who="Alex Larsson">

> On Sat, 15 Sep 2001, Darin Adler wrote:
> 
> > on 9/15/01 5:45 PM, Havoc Pennington at hp redhat com wrote:
> > 
> > > IIRC color is now autoselected instead of hardcoded. Apparently for
> > > the default theme it needs to remain hardcoded, or the autoselection
> > > needs improving.
> > 
> > Can someone who is familiar with this change take a crack at fixing it? Is
> > it a simple matter of re-adding the hard coded colors for now?
> > 
> > Was it important to remove those colors from the theme XML files? It seems
> > that we did it without even testing the themes we removed them from. Or
> > perhaps they had to be removed from the default theme to prevent other
> > themes from inheriting them?
> 
> I just took a look at the eel_background_is_dark() code. I did not compile 
> this, but i believe this patch should fix the problem:
> 
> Index: eel-gdk-pixbuf-extensions.c
> ===================================================================
> RCS file: /cvs/gnome/eel/eel/eel-gdk-pixbuf-extensions.c,v
> retrieving revision 1.9
> diff -u -p -r1.9 eel-gdk-pixbuf-extensions.c
> --- eel-gdk-pixbuf-extensions.c	2001/08/15 15:59:24	1.9
> +++ eel-gdk-pixbuf-extensions.c	2001/09/16 21:41:22
> @@ -314,9 +314,9 @@ eel_gdk_pixbuf_average_value (GdkPixbuf 
>  		}
>  	}
>  
> -	color->red =   (red_total   * 256) / count;
> -	color->green = (green_total * 256) / count;
> -	color->blue =  (blue_total  * 256) / count;
> +	color->red =   (red_total / count) * 256;
> +	color->green = (green_total / count) * 256;
> +	color->blue =  (blue_total / count) *256;
>  }
>  
>  double
> 
> 
> / Alex

I just applied this patch to my checkout of the eel-1-0 branch, and it does
indeed fix nautilus bug #46816 (icon text is not legible with certain
backgrounds, http://bugzilla.gnome.org/show_bug.cgi?id=46816) for me.

--Kenny