[Nautilus-list] Re: RH merge, DnD

on 9/4/01 1:01 PM, Alex Larsson at alexl redhat com wrote:

> Here is a DnD patch that makes drag and drop from the panel to the desktop
> and nautilus windows to work.

This is an improvement. It moves the code from the desktop view to all icon
views and adds a few things, but sadly it should be in FMDirectoryView. I
think it's OK to commit it as is.

A few comments though:

> According to jrb (who wrote it) it is sort of hackish, but is better that
> we currently have.

> +    if (gnome_vfs_uri_is_local (container_uri) == FALSE) {

We use ! for this sort of thing rather than == FALSE.

Also is "gnome_vfs_uri_is_local" the right check here? Aren't we really
talking about "file:" vs. non-"file:" in this case?

> +        eel_show_warning_dialog (_("An invalid drag type was used."),
> +                     _("Drag and Drop error"),

This sounds like a very strange message to show the user. I don't get it --
when does this happen?

    -- Darin

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]