[Nautilus-list] RE: [PATCH] Text view Patch

[Darin Adler <darin bentspoon com>]

Patch looks good.

> +    GtkWidget *disclamer;

It's "disclaimer", not "disclamer", I think.

> +    /* Create label and place it in frame if user level is set to
"Beginner"*/

This comment seems to be left over from when this varied based on user
level. It should match the code.

> +    disclamer = gtk_label_new("This text is read only\n  To edit it, choose
an option from the sidebar");

Normally, we do not use spaces for formatting, so the spaces after "\n" seem
like a mistake. Also, you forgot the space after gtk_label_new and before (.

> +    eel_gtk_label_make_larger (GTK_LABEL(disclamer), 3);

Does it really need to be 3 sizes bigger? How did you come up with that? Did
you try other sizes?

You forgot the space after GTK_LABEL and before (.

> +    eel_gtk_label_make_bold (GTK_LABEL(disclamer));

You forgot the space after GTK_LABEL and before (.

Even though Nautilus has lots of code that hardcodes stuff like this, I
think the "correct" gtk approach is to use a gtkrc file. Ideally, I'd like
to do that instead of the calls to eel_gtk_label_make_larger and
eel_gtk_label_make_bold. But that's not really necessary.

Fix the stuff I mentioned here (other than that last one) and post another
patch please. I think it's fine to put this in.

    -- Darin