Re: [Nautilus-list] FAM problems

[Alex Larsson <alexl redhat com>]

On 6 Oct 2001, Chris Heywood wrote:

> On Sat, 2001-10-06 at 01:35, Tuomas Kuosmanen wrote:
> > On Fri, 2001-10-05 at 18:07, Alex Larsson wrote:
> >     Please get fam 2.6.4-13 from rawhide. In 2.6.4-8 i added a fix to 
> >     situations like this (it got 'stuck' on the old user), and in 2.6.4-13 i 
> >     fixed a change-notify race that made nautilus show "0 bytes", because fam 
> >     didn't send enough change notifies.
> > 
> > Can you point me to a tarball (being debian on this ppc laptop)?
> 
> "me too".
> 
> debian here aswell.  are these changes going to go back into a new
> release of FAM?  or is nautilus going to depend on a redhat only
> version?

I mail my patches to the fam-list, but the maintainer is not very 
responsive.

/ Alex

Here are the patches in question:

diff -ur fam-oss-2.6.4.orig/fam/Listener.c++ fam-oss-2.6.4/fam/Listener.c++
--- fam-oss-2.6.4.orig/fam/Listener.c++	Tue Aug  7 13:03:44 2001
+++ fam-oss-2.6.4/fam/Listener.c++	Tue Aug  7 14:52:08 2001
@@ -213,6 +213,7 @@
     strcpy(sun.sun_path, tmpfile);
     free(tmpfile);
 
+    Cred::SuperUser.become_user();
     int client_sock = socket(PF_UNIX, SOCK_STREAM, 0);
     if (client_sock < 0)
     {   Log::perror("localclient socket(PF_UNIX, SOCK_STREAM, 0)");


--- fam-oss-2.6.4-alex/fam/Interest.c++.race	Tue Oct  2 16:05:45 2001
+++ fam-oss-2.6.4-alex/fam/Interest.c++	Tue Oct  2 16:14:12 2001
@@ -181,7 +181,14 @@
 
     bool exists = status.st_mode != 0;
     bool did_exist = old_stat.st_mode != 0;
-    bool stat_changed = old_stat.st_ctime != status.st_ctime;
+    bool stat_changed =
+      (old_stat.st_ctime != status.st_ctime) ||
+      (old_stat.st_mtime != status.st_mtime) ||
+      (old_stat.st_mode != status.st_mode) ||
+      (old_stat.st_uid != status.st_uid) ||
+      (old_stat.st_gid != status.st_gid) ||
+      (old_stat.st_size != status.st_size) ||
+      (old_stat.st_ino != status.st_ino);
     old_stat = status;
     
     if (exists && !did_exist)