Re: [Nautilus-list] nautilus-1.0.4-gmc.patch

[Alex Larsson <alexl redhat com>]

On 15 Nov 2001, Frederic Crozat wrote:

> le mer 14-11-2001 à 21:24, Alex Larsson a écrit :
> > On 14 Nov 2001, Frederic Crozat wrote:
> > 
> > > le lun 12-11-2001 à 19:55, Darin Adler a écrit :
> > > > > Here is another suggestion which could be used by all distributions :
> > > > > instead of copying start-here.desktop from $(datadir)/nautilus to
> > > > > ~/.gnome-desktop,
> > > > > 1- we create $(datadir)/nautilus/default-desktop and we put
> > > > > start-here.desktop
> > > > > 2- each distribution packager (and system administrator too) can add as
> > > > > many .desktop as they want in $(datadir)/nautilus/default-desktop, with
> > > > > a .nautilus-metafile.xml
> > > > > 3- create_starthere_link_callback is renamed into something like
> > > > > create_default_desktop_callback, and copy content of
> > > > > $(datadir)/nautilus/default-desktop into ~/.gnome-desktop
> > > > > 
> > > > > Are you ok with this design ? If so, I'll do a patch and will ask for
> > > > > review here..
> > > > 
> > > > Sounds good -- better than the gmc script thing.
> > > 
> > > I'm currently working on that and when I modified
> > > create_starthere_link_callback, I had problem with two files :
> > > start-here.desktop and start-here-link.desktop file. The
> > > start-here-link.desktop is copied on ~/.gnome-desktop as
> > > start-here.desktop so I don't see any use for start-here.desktop.. Is it
> > > really needed ?
> > 
> > Of course it's needed. It is typically used to place start-here on the 
> > panel. The start-here-link.desktop file is a link, and can't be 
> > "launched", whereas the start-here.desktop is launched nautilus with 
> > start-here as argument.
> 
> If start-here.desktop had been located in $datadir/gnome/apps, I would
> had understood but I didn't understood since it was in
> $datadir/nautilus...

But we don't want it in the programs menu.
 
> Ok, here is a patch to generalize the start-here mecanism. I've moved
> start-here-link.desktop.in to data/default-desktop and renamed it to
> start-here.desktop.in to simplify Makefile.am
> 
> I've also added a "Create Default Icons" in Desktop Background menu.
> 
> I'm waiting for your comments.. (the nautilus-metafile.xml copy is done
> to provide some way to set locations of default icons)

Looks fine to me, but you better wait for review by havoc or maciej.

/ Alex