[Nautilus-list] Re: Another patch for various components

[Darin Adler <darin bentspoon com>]

on 11/11/01 10:30 AM, Thomas Canty at tommydal optushome com au wrote:

> More work towards gettting the components working, the help component
> now works and tree component compiles and links,

Thanks.

Please use "diff -u" next time. It's hard to read a normal diff.

> 330c331
> <                      (gnome_i18n_get_language_list (NULL)));
> ---
> >                      ((GList *) gnome_i18n_get_language_list (NULL)));

This is OK, but lame. The gtk experts agree that GList * makes no sense, and
we should get libgnome fixed instead of adding casts to all our code.

> 790c791
> <     stxt = gtk_entry_get_text (GTK_ENTRY (hni->ent));
> ---
> >     stxt = (char *) gtk_entry_get_text (GTK_ENTRY (hni->ent));

This is the wrong fix. Instead, stxt needs to be changed to have the type
const char *.

> 912a913,914
> > GdkFont *font;
> > 
> 942a945,947
> > 
> > font = gtk_style_get_font (view->details->tree->style);
> > 
> 945,946c950,951
> <                        view->details->tree->style->font->ascent
> <                        + view->details->tree->style->font->descent));
> ---
> >                        font->ascent
> >                        + font->descent));

I'm not happy with us adding code that uses deprecated GdkFont. Isn't there
a non-deprecated Pango way of getting this information?

> 992c997
> <          nautilus_tree_view_update_all_icons,
> ---
> >          GTK_SIGNAL_FUNC (nautilus_tree_view_update_all_icons),

Should be G_CALLBACK. GTK_SIGNAL_FUNC is deprecated.

> Index: components/tree/Makefile.am
> ===================================================================
> RCS file: /cvs/gnome/nautilus/components/tree/Makefile.am,v
> retrieving revision 1.21
> diff -r1.21 Makefile.am
> 7a8
> > -DGTK_ENABLE_BROKEN                \

Why specifically do we need this? Is there a good way to avoid using the
broken stuff from GTK?

    -- Darin