Re: [Nautilus-list] Small optimization

> I'm not sure I'd consider this a real optimization. I'd bet that it doesn'
> t make a measurable difference; it's usually a mistake to "optimize" 
> existing code in a way that users can't detect.

  Of course I agree.  But in this case, it's just a couple of wasted
operations, without adding any clarity to the code.

> The concept of the patch is just fine, but it doesn't follow Nautilus 
> coding style guidelines. As described in nautilus/doc/style-guide.html, we 
> put all declarations at the top of the function, so the declarations 
> should be left outside the if statement.

  OK, I'll commit after this change.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]