Re: [Nautilus-list] John's .desktop icon patch

[Alex Larsson <alexl redhat com>]

On Fri, 22 Jun 2001, Maciej Stachowiak wrote:

> On 22Jun2001 04:06PM (-0400), Havoc Pennington wrote:
> >
> > John Harper <jsh pixelslut com> writes:
> > > Havoc Pennington writes:
> > > |Has this patch been merged into mainstream Nautilus? If not what
> > > |changes do I need to make to get it ready?
> > > |
> > > |This is John Harper's patch to dig icons out of .desktop files (if
> > > |those files are coming over VFS).
> > >
> > > The reason I didn't try to commit this to nautilus was because it used
> > > non-async vfs operations to read the .desktop files. I wasn't sure if
> > > this was acceptable (and I couldn't think of an alternative)
> > >
> >
> > For the controlled use-cases I have in mind (preferences:, sysconfig:,
> > starthere:, favorites:, programs:) I think it would be fine, maybe
> > we could put in some hack to be sure we don't try to do the non-async
> > for http: or giant directories?
> >
>
> If feasible, it would be nicest to restructure the patch to use async
> I/O for this. I'd be glad to help you figure it out, I'm pretty
> familiar with the Nautilus async I/O machinery.

And if you do this, could you at the same time try to fix loading of Icons
from remote NautilusLinks. That is needed for getting nice icons in the
smb browser.

/ Alex