Re: [Nautilus-list] [PATCH]: Avoid directory reload when FAM is active.

[Darin Adler <darin bentspoon com>]

On Monday, June 18, 2001, at 02:58  AM, Yoann Vandoorselaere wrote:

> Darin Adler <darin bentspoon com> writes:
> > Just checking if the monitor is active is not enough. You also have to
> > check that the directory in question is a "file://" directory and not
> > another kind of URL. Also, you have to explicitly check that this is
> > not the reload case, since reload won't actually do any reloading
> > without the code, and we do want reload to cause a reload even with
> > the file monitoring on. So we need 3 checks, not just this single one.
>
> There is no need for a third check...
> You just need to add a nautilus_directory_force_reload() in
> nautilus_window_reload().

There are advantages to having a third check rather than a separate call 
to force_reload, but I agree that it's another type of solution to the 
problem. The fact remains that your patch gets this wrong, because it 
neither has a third check or an added call in nautilus_window_reload.

    -- Darin